[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHQ1cqHyw8BXxpMVRmFTUP9HUy6TAau48wZc3=XJB8ZexuVkjw@mail.gmail.com>
Date: Tue, 21 Jun 2016 16:51:26 -0700
From: Andrey Smirnov <andrew.smirnov@...il.com>
To: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc: rtc-linux@...glegroups.com,
Alessandro Zummo <a.zummo@...ertech.it>,
linux-kernel@...r.kernel.org, Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH v2 00/17] DS1341 support and code cleanup
>>
>> Andrey Smirnov (17):
>> RTC: ds1307: Add DS1341 variant
>> RTC: ds1307: Disable square wave and timers as default
>> RTC: ds1307: Add devicetree bindings for DS1341
>> RTC: ds1307: Add DS1341 specific power-saving options
>> RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate
>> RTC: ds1307: Convert want_irq into a predicate
>
> I'll have to triple check that one, it breaks in thousand different
> ways, every time someone touches that code :)
Wouldn't you agree that this might be an indication that the code is a
bit convoluted and some cleanup is in order? ;-)
>
>> RTC: ds1307: Move chip configuration into a separate routine
>> RTC: ds1307: Move chip sanity checking into a separate routine
>
> I'm not sure about the cleanup in those two patches yet, It moves a lot
> of code and the readability improvement is not obvious
OK, I agree that this patch moves a lot of code, and can't really
argue with "not obvious" since that is subjective. Please let me know
what you decide and I'll change v3 appropriately.
Thanks,
Andrey
Powered by blists - more mailing lists