linux-kernel - Re: [PATCH] mmc: core: add auto bkops support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jun 2016 09:38:16 +0900
From:	Jaehoon Chung <jh80.chung@...sung.com>
To:	Alex Lemberg <Alex.Lemberg@...disk.com>,
	Shawn Lin <shawn.lin@...k-chips.com>,
	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	Adrian Hunter <adrian.hunter@...el.com>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Doug Anderson <dianders@...omium.org>,
	"linux-rockchip@...ts.infradead.org" 
	<linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH] mmc: core: add auto bkops support

On 06/20/2016 10:33 PM, Alex Lemberg wrote:
> Hi Shawn,
> 
> […]
> 
>>>> +
>>>> +static int mmc_stop_auto_bkops(struct mmc_card *card)
>>>> +{
>>>> +	int err = 0;
>>>> +
>>>> +	if (!card->ext_csd.auto_bkops_en)
>>>> +		return 0;
>>>> +
>>>
>>> Shouldn’t the BKOPS_STATUS be checked prior to disabling the BKOPS activity of the device?
>>>
>>
>> Hrmm.. I read the whole section of spec for it, and I did find this
>> requirement for manul bkops but not for the auto one. So what should we
>> do if using the auto one?
>>
> 
> In case of AUTO BKOPS, the eMMC Device should perform internal GC 
> in the same way as in case of MANUAL BKOPS.
> The only difference is a host awareness. 
> Although there is no requirement in the spec, I think the driver can
> give some time to the device to perform/complete its internal GC during the idle time.
> Thus I think we can check the BKOPS_STATUS on Runtime suspend.

I'm not sure we can check BKOPS_STATUS when use the AUTO_BKOPS.
I have also read the SPEC, but it's not clearly for checking the BKOPS_STATUS.
Just i understood that it should be operated without a host's awareness.

Best Regards,
Jaehoon Chung

> 
> […]
> 
> Thanks,
> Alex
>