linux-kernel - RE: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jun 2016 10:21:15 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Roger Quadros <rogerq@...com>,
	"peter.chen\@freescale.com" <peter.chen@...escale.com>
Cc:	"tony\@atomide.com" <tony@...mide.com>,
	"gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>,
	"dan.j.williams\@intel.com" <dan.j.williams@...el.com>,
	"mathias.nyman\@linux.intel.com" <mathias.nyman@...ux.intel.com>,
	"Joao.Pinto\@synopsys.com" <Joao.Pinto@...opsys.com>,
	"sergei.shtylyov\@cogentembedded.com" 
	<sergei.shtylyov@...entembedded.com>,
	"jun.li\@freescale.com" <jun.li@...escale.com>,
	"grygorii.strashko\@ti.com" <grygorii.strashko@...com>,
	"robh\@kernel.org" <robh@...nel.org>,
	"nsekhar\@ti.com" <nsekhar@...com>, "b-liu\@ti.com" <b-liu@...com>,
	"joe\@perches.com" <joe@...ches.com>,
	"linux-usb\@vger.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-omap\@vger.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree\@vger.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH v11 08/14] usb: otg: add OTG/dual-role core


Hi,

Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> writes:
> Hi Roger,
>
>> From: Roger Quadros
>> Sent: Monday, June 20, 2016 7:13 PM
>> 
>> Hi,
>> 
>> On 20/06/16 10:45, Felipe Balbi wrote:
> < snip >
>> >> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
>> >> index f4fc0aa..1d74fb8 100644
>> >> --- a/include/linux/usb/gadget.h
>> >> +++ b/include/linux/usb/gadget.h
>> >> @@ -328,6 +328,7 @@ struct usb_gadget_ops {
>> >>   * @in_epnum: last used in ep number
>> >>   * @mA: last set mA value
>> >>   * @otg_caps: OTG capabilities of this gadget.
>> >> + * @otg_dev: OTG controller device, if needs to be used with OTG core.
>> >
>> > do you really know of any platform which has a separate OTG controller?
>> >
>> 
>> Andrew had pointed out in [1] that Tegra210 has separate blocks for OTG, host
>> and gadget.
>> 
>> [1] http://article.gmane.org/gmane.linux.ports.tegra/22969
>> 
>> Yoshihiro,
>> 
>> How is the dual-role architecture on your Renesas platform?
>
> About the dual-role architecture, Renesas platform (R-Car H3) has a
> USB 2.0 host controller (EHCI/OHCI) with OTG function and a separate
> USB 2.0 peripheral controller (HS-USB).  The OTG function is related
> to some PHY control registers, so I intend to add the OTG/Dual-role
> core support into the phy driver (drivers/phy/phy-rcar-gen3-usb2.c).

that looks like a mux to me :-) thanks for the pointer

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)