linux-kernel - Re: [PATCH 0/3] Fixes on remote unwind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160621073315.GA13670@krava>
Date:	Tue, 21 Jun 2016 09:33:15 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	He Kuang <hekuang@...wei.com>
Cc:	peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
	alexander.shishkin@...ux.intel.com, wangnan0@...wei.com,
	jpoimboe@...hat.com, ak@...ux.intel.com, eranian@...gle.com,
	namhyung@...nel.org, adrian.hunter@...el.com,
	sukadev@...ux.vnet.ibm.com, masami.hiramatsu.pt@...achi.com,
	tumanova@...ux.vnet.ibm.com, kan.liang@...el.com,
	penberg@...nel.org, dsahern@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Fixes on remote unwind

On Wed, Jun 08, 2016 at 10:15:35AM +0000, He Kuang wrote:
> The remote unwind can supported scenario where we collect on a x86_64
> machine and want to do analysis on a ARM64 or x86-32 machine. Though
> this is not tested, after Arnaldo questioned the above issue, I tested
> and found a bug.
> 
> In util/unwind-libunwind-local.c, PERF_REG_SP/IP is used, but those
> macros are assigned to the host platform, we should redefine them in
> the wrapper file, for example in "util/libunwind/x86_32.c".
> 
> After fixing this problem, i686 perf.data can be parsed on aarch64
> machine.
> 
> To Arnaldo, I noticed that this patch
> "perf tools: Find vdso supporting cross-platform analysis"
> is not on "origin/perf/unwind" branch, this patch was applied, please
> check if it was missed, the above test needs this patch.
> 
> Thank you.
> 
> He Kuang (3):
>   perf unwind: Change macro names of perf register
>   perf unwind: Fix wrongly used regs for x86_32 unwind
>   perf unwind: Fix wrongly used regs for aarch64 unwind

for the patchset:

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka