linux-kernel - Re: [PATCH] scripts/bloat-o-meter: fix percent change output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jun 2016 08:00:05 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Vineet Gupta" <Vineet.Gupta1@...opsys.com>
Subject: Re: [PATCH] scripts/bloat-o-meter: fix percent change output

Hi Heiko,

On Tuesday 21 June 2016 01:10 PM, Heiko Carstens wrote:
> commit b21e91c305bc "scripts/bloat-o-meter: print percent change"
> introduced an additional line to the output of the bloat-a-meter
> script which shows the percent change. However it uses integer instead
> of floating point arithmetics.
>
> Let's enforce floating point arithmetics to improve the output (note
> "chg"):

There's already a (slightly better) patch in flight to same effect:
http://marc.info/?l=linux-kernel&m=146598033302242

-Vineet

> Before:
>
> add/remove: 0/0 grow/shrink: 2/0 up/down: 24/0 (24)
> function                                     old     new   delta
> condev_setup                                  96     114     +18
> vermagic                                      58      64      +6
> Total: Before=24794284, After=24794308, chg 0.000000%
>
> After:
>
> add/remove: 0/0 grow/shrink: 2/0 up/down: 24/0 (24)
> function                                     old     new   delta
> condev_setup                                  96     114     +18
> vermagic                                      58      64      +6
> Total: Before=24794284, After=24794308, chg 0.000097%
>
> Cc: Vineet Gupta <Vineet.Gupta1@...opsys.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
> ---
>  scripts/bloat-o-meter | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
> index 0254f3ba0dba..5a5d383004f5 100755
> --- a/scripts/bloat-o-meter
> +++ b/scripts/bloat-o-meter
> @@ -68,4 +68,4 @@ for d, n in delta:
>      if d: print("%-40s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d))
>  
>  print("Total: Before=%d, After=%d, chg %f%%" % \
> -    (otot, ntot, (ntot - otot)*100/otot))
> +    (otot, ntot, (ntot - otot)*100.0/otot))