linux-kernel - Re: linux-next: build warnings after merge of the pci tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 20 Jun 2016 20:27:03 -0500
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Bjorn Helgaas <helgaas@...nel.org>,
	linux-next list <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warnings after merge of the pci tree

On Mon, Jun 20, 2016 at 8:08 PM, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> Hi Bjorn,
>
> On Mon, 20 Jun 2016 14:11:36 -0500 Bjorn Helgaas <helgaas@...nel.org> wrote:
>>
>> On Mon, Jun 20, 2016 at 11:52:13AM +1000, Stephen Rothwell wrote:
>> > Hi Bjorn,
>> >
>> > After merging the pci tree, today's linux-next build (arm
>> > multi_v7_defconfig) produced these warnings:
>> >
>> > drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
>> > drivers/pci/host/pci-host-common.c:88:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> >    return err;
>> >           ^
>> > drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> >    return PTR_ERR(cfg);
>> >           ^
>> > drivers/pci/host/pci-host-common.c:108:9: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> >   return err;
>> >          ^
>> >
>> > Introduced by commit
>> >
>> >   3f8dcfc3fbba ("PCI: generic: Free resource list close to where it's allocated")
>>
>> Fixed, thanks a lot, Stephen!
>
> Thanks.  Unfortunately, I still get this warning:
>
> drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
> drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>    return PTR_ERR(cfg);
>           ^

Crap, sorry, PTR_ERR/ERR_PTR confusion.  I *think* I fixed it now.

Bjorn