linux-kernel - Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE. Use it in LDST_PCREL and LDST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mvm60t2rjkq.fsf@hawking.suse.de>
Date:	Tue, 21 Jun 2016 11:13:09 +0200
From:	Andreas Schwab <schwab@...e.de>
To:	Yury Norov <ynorov@...iumnetworks.com>
Cc:	<libc-alpha@...rceware.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <catalin.marinas@....com>,
	<marcus.shawcroft@....com>, <philb@....org>, <davem@...emloft.net>,
	<szabolcs.nagy@....com>, <maxim.kuvyrkov@...aro.org>,
	<joseph@...esourcery.com>, <pinskia@...il.com>,
	Andrew Pinski <apinski@...ium.com>
Subject: Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE.  Use it in LDST_PCREL and LDST_GLOBAL.

Andreas Schwab <schwab@...e.de> writes:

>> +/* Load or store to/from a got-relative EXPR into/from R, using T.
>> +   Note R and T are register numbers and not register names.  */
>> +#define LDST_GLOBAL(OP, R, T,  EXPR)			\
>> +	adrp	x##T, :got:EXPR;			\
>> +	ldr	PTR_REG (T), [x##T, #:got_lo12:EXPR];	\
>> +	OP	x##R, [x##T];
>
> I think this needs to be PTR_REG(x).

I mean PTR_REG(R), of course.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@...e.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."