linux-kernel - Re: [PATCH V2 resend] libata:fix kernel panic when hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4hnzAoiPQNHD_6C74exQrDQGaGG-fRw8XAAkj80bv5nqg@mail.gmail.com>
Date:	Mon, 20 Jun 2016 18:46:55 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>
Cc:	Tejun Heo <tj@...nel.org>, DingXiang <dingxiang@...wei.com>,
	jejb@...ux.vnet.ibm.com, Wei Fang <fangwei1@...wei.com>,
	miaoxie@...wei.com, wangyijing@...wei.com, zhangaihua1@...wei.com,
	zhaohongjiang@...wei.com, houtao1@...wei.com,
	linux-scsi <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 resend] libata:fix kernel panic when hotplug

On Mon, Jun 20, 2016 at 6:22 PM, Martin K. Petersen
<martin.petersen@...cle.com> wrote:
>>>>>> "Tejun" == Tejun Heo <tj@...nel.org> writes:
>
>>> In fact,we don't need libata to deal with hotplug in sas environment.
>>> So we can't run ata hotplug task when ata port is sas host.
>
> Tejun> Martin, can you please confirm whether the above is true.  If so,
> Tejun> I'll route the patch through libata w/ stable cc'd.
>
> Not exactly a libsas expert. James? Dan?

While it is true that libsas itself handles adding / removing devices
we have historically avoided this conflict because
ATA_PFLAG_SCSI_HOTPLUG is never set for libsas ata_ports.  So the bug
/ behavior change is that  ATA_PFLAG_SCSI_HOTPLUG gets set in the
first place.  Ignoring it is a band-aid / not the real fix afaics.