linux-kernel - [PATCH] net: ethernet: fix odd_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1606211201310.2882@hadrien>
Date:	Tue, 21 Jun 2016 12:03:28 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	thloh@...era.com
cc:	robh+dt@...nel.org, mark.rutland@....com, peppe.cavallaro@...com,
	alexandre.torgue@...com, davem@...emloft.net,
	preid@...ctromag.com.au, dinguyen@...nsource.altera.com,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, thloh85@...il.com,
	cnphoon@...era.com, thloh@...era.com, kbuild-all@...org
Subject: [PATCH] net: ethernet: fix odd_ptr_err.cocci warnings

PTR_ERR should normally access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Tien Hock Loh <thloh@...era.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

This patch refers to the following code:

url:
https://github.com/0day-ci/linux/commits/thloh-altera-com/net-ethernet-Add-T
SE-PCS-support-to-dwmac-socfpga/20160621-164854

 dwmac-socfpga.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -224,7 +224,7 @@ static int socfpga_dwmac_parse_data(stru
 				dev_err(dev,
 					"%s: ERROR: failed mapping tse control port\n",
 					__func__);
-				return PTR_ERR(dwmac->pcs.sgmii_adapter_base);
+				return PTR_ERR(dwmac->pcs.tse_pcs_base);
 			}
 		}
 	}