linux-kernel - Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jun 2016 13:56:26 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	Tony Lindgren <tony@...mide.com>
Cc:	Peter Chen <hzpeterchen@...il.com>, Roger Quadros <rogerq@...com>,
	peter.chen@...escale.com, gregkh@...uxfoundation.org,
	dan.j.williams@...el.com, mathias.nyman@...ux.intel.com,
	Joao.Pinto@...opsys.com, sergei.shtylyov@...entembedded.com,
	jun.li@...escale.com, grygorii.strashko@...com,
	yoshihiro.shimoda.uh@...esas.com, robh@...nel.org, nsekhar@...com,
	b-liu@...com, joe@...ches.com, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core


Hi,

Tony Lindgren <tony@...mide.com> writes:
> * Felipe Balbi <balbi@...nel.org> [160621 03:06]:
>> 8<----------------------------------------------------------------------
>> 	vbus = read(VBUS_STATE); /* could be a gpio_get_value() */
>>         id = read(ID_STATE); /* could be a gpio_get_value() */
>> 
>>         set_role(id);
>>         set_vbus(vbus);
>
> We should use regulator framework API for set_vbus() because of
> the delays involved bringing it up. And we already have separate
> PHY and charger chips where VBUS is provided by the charger chip.

yeah, no arguments there.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)