linux-kernel - Re: [PATCH 10/27] [AARCH64] Detect ILP32 in configure scripts.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1606211029070.4526@digraph.polyomino.org.uk>
Date:	Tue, 21 Jun 2016 10:30:39 +0000
From:	Joseph Myers <joseph@...esourcery.com>
To:	Yury Norov <ynorov@...iumnetworks.com>
CC:	<libc-alpha@...rceware.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <catalin.marinas@....com>,
	<marcus.shawcroft@....com>, <philb@....org>, <davem@...emloft.net>,
	<szabolcs.nagy@....com>, <maxim.kuvyrkov@...aro.org>,
	<pinskia@...il.com>, Andrew Pinski <apinski@...ium.com>
Subject: Re: [PATCH 10/27] [AARCH64] Detect ILP32 in configure scripts.

On Tue, 21 Jun 2016, Yury Norov wrote:

> diff --git a/sysdeps/aarch64/preconfigure b/sysdeps/aarch64/preconfigure
> index d9bd1f8..4bcd8e3 100644
> --- a/sysdeps/aarch64/preconfigure
> +++ b/sysdeps/aarch64/preconfigure
> @@ -1,6 +1,15 @@
>  case "$machine" in
>  aarch64*)
>  	base_machine=aarch64
> -	machine=aarch64
> +	case "$CC $CFLAGS $CPPFLAGS " in
> +		*" -mabi=ilp32 "*) aarch64_config_abi=ilp32 ;;
> +		*" -mabi=lp64 "*) aarch64_config_abi=lp64 ;;
> +		*) aarch64_config_abi=default ;;

My comments in 
<https://sourceware.org/ml/libc-alpha/2014-10/msg00639.html> still apply: 
test how the compiler behaves instead.

> +if test $aarch64_config_abi = ilp32; then
> +  arch_minimum_kernel=3.19.0

My comments in 
<https://sourceware.org/ml/libc-alpha/2014-10/msg00639.html> still apply: 
use 10.0.0 until the corresponding kernel support is in, then change to 
the actual kernel version with the support.

-- 
Joseph S. Myers
joseph@...esourcery.com