linux-kernel - Re: [PATCH v12 4/4] power: wm831x_power: Support USB charger current limit management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r3bqn4l8.fsf@linux.intel.com>
Date:	Tue, 21 Jun 2016 14:50:27 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	Baolin Wang <baolin.wang@...aro.org>, gregkh@...uxfoundation.org,
	sre@...nel.org, dbaryshkov@...il.com, dwmw2@...radead.org,
	robh@...nel.org, jun.li@....com, m.szyprowski@...sung.com,
	ruslan.bilovol@...il.com, peter.chen@...escale.com,
	stern@...land.harvard.edu, r.baldyga@...sung.com,
	grygorii.strashko@...com, yoshihiro.shimoda.uh@...esas.com,
	lee.jones@...aro.org, ckeepax@...nsource.wolfsonmicro.com,
	patches@...nsource.wolfsonmicro.com, linux-pm@...r.kernel.org,
	linux-usb@...r.kernel.org,
	device-mainlining@...ts.linuxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 4/4] power: wm831x_power: Support USB charger current limit management


Hi,

Mark Brown <broonie@...nel.org> writes:
> [ Unknown signature status ]
> On Tue, Jun 21, 2016 at 01:30:49PM +0300, Felipe Balbi wrote:
>> Baolin Wang <baolin.wang@...aro.org> writes:
>> > @@ -607,8 +647,31 @@ static int wm831x_power_probe(struct platform_device *pdev)
>> >  		}
>> >  	}
>
>> > +	if (wm831x_pdata && wm831x_pdata->usb_gadget) {
>> > +		power->usb_charger =
>> > +			usb_charger_find_by_name(wm831x_pdata->usb_gadget);
>
>> the fact that you rely on strings and pass them via pdata is an
>> indication that you don't have enough description of the HW. Seems like
>> we need to come up with a set of DT properties which tie a charger to a
>> UDC.
>
>> I'm thinking a phandle would be enough?
>
> The wm831x has no DT support currently.

okay, perhaps its time to add it.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)