linux-kernel - Re: [PATCH 19/27] [AARCH64] Add typesizes.h for ILP32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57692C1F.8050309@huawei.com>
Date:	Tue, 21 Jun 2016 19:59:27 +0800
From:	"Zhangjian (Bamvor)" <bamvor.zhangjian@...wei.com>
To:	Andreas Schwab <schwab@...e.de>,
	Yury Norov <ynorov@...iumnetworks.com>
CC:	<libc-alpha@...rceware.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <catalin.marinas@....com>,
	<marcus.shawcroft@....com>, <philb@....org>, <davem@...emloft.net>,
	<szabolcs.nagy@....com>, <maxim.kuvyrkov@...aro.org>,
	<joseph@...esourcery.com>, <pinskia@...il.com>,
	Andrew Pinski <apinski@...ium.com>, <gaoyongliang@...wei.com>,
	"Zhangjian (Bamvor)" <bamvor.zhangjian@...wei.com>
Subject: Re: [PATCH 19/27] [AARCH64] Add typesizes.h for ILP32

Hi,

On 2016/6/21 15:58, Andreas Schwab wrote:
> Yury Norov <ynorov@...iumnetworks.com> writes:
>
>> diff --git a/sysdeps/unix/sysv/linux/sysdep-vdso.h b/sysdeps/unix/sysv/linux/sysdep-vdso.h
>> index e8c4a7b..351d6bb 100644
>> --- a/sysdeps/unix/sysv/linux/sysdep-vdso.h
>> +++ b/sysdeps/unix/sysv/linux/sysdep-vdso.h
>> @@ -37,7 +37,7 @@
>>       __label__ out;							      \
>>       __label__ iserr;							      \
>>       INTERNAL_SYSCALL_DECL (sc_err);					      \
>> -    long int sc_ret;							      \
>> +    __syscall_slong_t sc_ret;						      \
>>   									      \
>>       __typeof (__vdso_##name) vdsop = __vdso_##name;			      \
>>       PTR_DEMANGLE (vdsop);						      \
>> @@ -64,7 +64,7 @@
>>   #  define INTERNAL_VSYSCALL(name, err, nr, args...)			      \
>>     ({									      \
>>       __label__ out;							      \
>> -    long v_ret;								      \
>> +    __syscall_slong_t v_ret;						      \
>>   									      \
>>       __typeof (__vdso_##name) vdsop = __vdso_##name;			      \
>>       PTR_DEMANGLE (vdsop);						      \
>
> That part should have no effect now that __SYSCALL_SLONG_TYPE remains to
> be long.
Agree. According to the discussion in "[PATCH 11/27] [AARCH64] Syscalls for ILP32 are passed
always via 64bit values.". We should update this to long long too.

Regard

Bamvor
>
> Andreas.
>