linux-kernel - Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160621144645.GF11432@8bytes.org>
Date:	Tue, 21 Jun 2016 16:46:46 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	Suravee Suthikulanit <suravee.suthikulpanit@....com>
Cc:	pbonzini@...hat.com, rkrcmar@...hat.com,
	alex.williamson@...hat.com, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, sherry.hurwitz@....com
Subject: Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

On Tue, Jun 21, 2016 at 09:27:27AM -0500, Suthikulpanit, Suravee wrote:
> On 6/21/2016 8:50 AM, Joerg Roedel wrote:
> >The code has a few style issues (thing I'd implemented differently), but
> >it looks functional.
> 
> Anything in particular that you think I should improve or/and change?

One thing I noticed were all the if (small IRTE) ... else (big IRTE)
that would better be hidden behind function pointers. Also a few magic
numbers are in there that could be replaced by proper defines.



	Joerg