linux-kernel - Re: [PATCH v2 2/2] pci: host: new driver for Axis ARTPEC-6 PCIe controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160621145819.GA31917@localhost>
Date:	Tue, 21 Jun 2016 09:58:19 -0500
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	Niklas Cassel <niklas.cassel@...s.com>, bhelgaas@...gle.com,
	niklass@...s.com, jespern@...s.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	mchehab@....samsung.com, linux@...ck-us.net, jslaby@...e.cz,
	robh@...nel.org, marc.zyngier@....com, rjui@...adcom.com,
	Arnd Bergmann <arnd@...db.de>,
	David Daney <david.daney@...ium.com>, geert+renesas@...der.be,
	lftan@...era.com, bharat.kumar.gogada@...inx.com, hauke@...ke-m.de,
	thomas.petazzoni@...e-electrons.com, simon.horman@...ronome.com,
	phil.edworthy@...esas.com, svarbanov@...sol.com, dhdang@....com,
	wangzhou1@...ilicon.com, LKML <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org, linux-arm-kernel@...s.com
Subject: Re: [PATCH v2 2/2] pci: host: new driver for Axis ARTPEC-6 PCIe
 controller

On Mon, Jun 20, 2016 at 03:50:07PM -0400, Paul Gortmaker wrote:
> On Mon, May 9, 2016 at 7:49 AM, Niklas Cassel <niklas.cassel@...s.com> wrote:
> > From: Niklas Cassel <niklas.cassel@...s.com>
> >
> > The Axis ARTPEC-6 SoC integrates a PCIe controller from Synopsys.
> > This commit adds a new driver that provides the small glue
> > needed to use the existing Designware driver to make it work on
> > the Axis ARTPEC-6 SoC.
> >
> > Signed-off-by: Niklas Cassel <niklas.cassel@...s.com>
> 
> [...]
> 
> > --- a/drivers/pci/host/Kconfig
> > +++ b/drivers/pci/host/Kconfig
> > @@ -244,4 +244,10 @@ config PCIE_ARMADA_8K
> >           Designware hardware and therefore the driver re-uses the
> >           Designware core functions to implement the driver.
> >
> > +config PCIE_ARTPEC6
> > +       bool "Axis ARTPEC-6 PCIe controller"
> 
> Bjorn,
> 
> Can we please start requiring new PCI/PCI-e drivers to either:
> 
>   (a)  be merged and tested as tristate, or
> 
>   (b)  remain bool, but not gratuitously use module macros

That requires somebody to enforce it, which I suppose would end up
being me, and that's not really practical unless you help out by
watching for them.  I know that's not really practical for you either.

I hoped that we could convert them to be modular, but that hasn't
started happening, so I think we need to fall back to your original
proposal of making them bool and removing the modular junk.
Eventually people who feel the pain of building in all the drivers
might step up and make them modular.

Do you want to update your series that removed the gratuitous module
code?  I'll be on vacation June 25-July 17, but maybe we can still
squeeze it in this cycle.

Bjorn