linux-kernel - Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1688032.bsOGLjkyBG@vostro.rjw.lan>
Date:	Tue, 21 Jun 2016 17:11:41 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
Cc:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Robert Moore <robert.moore@...el.com>,
	Lv Zheng <lv.zheng@...el.com>,
	"Rafael J.Wysocki" <rafael.j.wysocki@...el.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Len Brown <lenb@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Rob Herring <robh+dt@...nel.org>,
	Frank Rowand <frowand.list@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Support Opensource <Support.Opensource@...semi.com>,
	Sathyanarayana Nujella <sathyanarayana.nujella@...el.com>
Subject: Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

On Tuesday, June 21, 2016 11:50:01 AM Opensource [Adam Thomson] wrote:
> 21 June 2016 12:42, Rafael J. Wysocki wrote:
> 
> > > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode,
> > > > +					const char *name)
> > > > +{
> > > > +	return is_acpi_data_node(fwnode) ?
> > > > +		(!strcasecmp(to_acpi_data_node(fwnode)->name, name)) : false;
> > > > +}
> > >
> > > Looks fine to me.
> > >
> > > One question - is it expected that matching ACPI data nodes is always
> > > case insensitive?
> > 
> > That would not be a correct expectation in theory, although I don't think it
> > really matters in practice.
> 
> From my reading of the Hierarchical Data Extension and ACPI Spec, I thought
> that was the case (section 19.3.1 ASL Names - ASL names are not case-sensitive
> and will be converted to upper case).

Section 19.3.1 is applicable to object names and not to the data returned
by those objects.  The link names in the Hierarchical Data Extension are
data returned by _DSD (or other objects related to it).  They are general ACPI
strings and those are case-sensitive.

Thanks,
Rafael