linux-kernel - Re: [PATCH 1/6] memory: atmel-sdramc: make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160621151728.GU5809@piout.net>
Date:	Tue, 21 Jun 2016 17:17:28 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org,
	Nicolas Ferre <nicolas.ferre@...el.com>
Subject: Re: [PATCH 1/6] memory: atmel-sdramc: make it explicitly non-modular

On 16/06/2016 at 20:37:43 -0400, Paul Gortmaker wrote :
> The Kconfig for this option is currently:
> 
> config ATMEL_SDRAMC
>         bool "Atmel (Multi-port DDR-)SDRAM Controller"
> 
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove the couple traces of modularity, so that when reading the
> driver there is no doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.  An
> alternate init level might be worth considering at a later date.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> Cc: Nicolas Ferre <nicolas.ferre@...el.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/memory/atmel-sdramc.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com