linux-kernel - Re: [PATCH V3] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160622095723.GU26668@lukather>
Date:	Wed, 22 Jun 2016 11:57:23 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	luoyi.ly@...il.com
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linux@....linux.org.uk, wens@...e.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-sunxi@...glegroups.com
Subject: Re: [PATCH V3] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus
 board

Hi,

On Fri, Jun 17, 2016 at 05:56:02PM +0800, luoyi.ly@...il.com wrote:
> From: Luo Yi <luoyi.ly@...il.com>
> 
> Add support for the Bananapi M1 Plus A20 development board from
> sinovoip.com.cn . This board is nearly a clone of the Lemaker's
> Bananapro, but differ with the wlan chipset connection and i2s pinout.
> And I also enable the integrated audio codec on default.

This patch content is fine, but there's a lot of small issues:
  - You're not indenting the nodes properly
  - You're missing your Signed-off-by tag
  - And probably other stuff

This has all been reported by checkpatch.

Make sure you run checkpatch, make the modifications needed so that
you don't have any warnings or errors anymore, and resubmit it.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)