linux-kernel - Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <op.yjge1dkz2s3iss@ecaz>
Date:	Wed, 22 Jun 2016 12:21:03 +0200
From:	"Imre Kaloz" <kaloz@...nwrt.org>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	"Mark Rutland" <mark.rutland@....com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@...r.kernel.org>,
	"Florian Fainelli" <f.fainelli@...il.com>,
	"Pawel Moll" <pawel.moll@....com>,
	"Ian Campbell" <ijc+devicetree@...lion.org.uk>,
	"Hauke Mehrtens" <hauke@...ke-m.de>,
	"Russell King" <linux@...linux.org.uk>,
	"open list" <linux-kernel@...r.kernel.org>,
	"Rob Herring" <robh+dt@...nel.org>,
	"open list:BROADCOM BCM5301X ARM ARCHITECTURE" 
	<bcm-kernel-feedback-list@...adcom.com>,
	"Kumar Gala" <galak@...eaurora.org>,
	"open list:BROADCOM BCM5301X ARM ARCHITECTURE" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear
 R7000

On Tue, 21 Jun 2016 17:23:18 +0200, Rafał Miłecki <zajec5@...il.com> wrote:

> On 21 June 2016 at 16:29, Imre Kaloz <kaloz@...nwrt.org> wrote:
>> On Tue, 21 Jun 2016 14:26:11 +0200, Rafał Miłecki <zajec5@...il.com>  
>> wrote:
>>
>>> On 21 June 2016 at 14:22, Imre Kaloz <kaloz@...nwrt.org> wrote:
>>>>
>>>> Is there any reason you are not handling this properly as a regulator
>>>> with
>>>> usb-nop-xceiv?
>>>
>>>
>>> We can't use USB NOP PHY as we need a specific PHY driver for  
>>> Broadcom's
>>> USB.
>>
>>
>> I see. That shouldn't stop you from addressing the regulator part, tho  
>> ;)
>
> How? Be more specific please.
>

Instead of blindly enabling a GPIO, you should define that GPIO line as a  
fixed regulator and make the USB phy driver handle it. Take a look at  
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7776ab70d75ff9857343e44e428744d81c30ce1b  
for example.


Imre