linux-kernel - Re: [Y2038] [PATCH v2 09/24] fs: udf: Replace CURRENT_TIME with current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8704234.tYHdNQJqxT@wuerfel>
Date:	Wed, 22 Jun 2016 15:54:26 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	y2038@...ts.linaro.org
Cc:	Deepa Dinamani <deepa.kernel@...il.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	tytso@....edu, viro@...iv.linux.org.uk, Jan Kara <jack@...e.com>,
	tglx@...utronix.de, torvalds@...ux-foundation.org
Subject: Re: [Y2038] [PATCH v2 09/24] fs: udf: Replace CURRENT_TIME with current_time()

On Sunday, June 19, 2016 5:27:08 PM CEST Deepa Dinamani wrote:
>         mutex_lock(&sbi->s_alloc_mutex);
>         lvidiu->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX;
>         lvidiu->impIdent.identSuffix[1] = UDF_OS_ID_LINUX;
> +       ktime_get_real_ts(&ts);
>         udf_time_to_disk_stamp(&lvid->recordingDateAndTime,
> -                               CURRENT_TIME);
> +                               timespec_trunc(ts, sb->s_time_gran));
>         lvid->integrityType = cpu_to_le32(LVID_INTEGRITY_TYPE_OPEN);
>  
>         lvid->descTag.descCRC = cpu_to_le16(
> 

I think we don't need the timespec_trunc here, and introducing the
call might complicate matters in the future.

IMHO timespec_trunc() really only makes sense when assigning into
an inode timestamp, whereas udf_time_to_disk_stamp() already truncates
the resulting nanoseconds to microseconds.

	Arnd