linux-kernel - Re: [PATCH 3/4] dell-wmi: Add information about other WMI event codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160622142407.GH29844@pali>
Date:	Wed, 22 Jun 2016 16:24:07 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Mario_Limonciello@...l.com
Cc:	gabriele.mzt@...il.com, mjg59@...f.ucam.org, dvhart@...radead.org,
	kernel@...pniu.pl, luto@...nel.org, alex.hung@...onical.com,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] dell-wmi: Add information about other WMI event codes

On Wednesday 22 June 2016 14:21:25 Mario_Limonciello@...l.com wrote:
> > > For Linux I don’t think this is necessary and a NOOP is appropriate.
> > >
> > > There is also a second place that some older laptops had a battery "hotkey"
> > > that would also emit 0xE00E.  This was also picked up by quickset and would
> > > show battery information.
> > >
> > > This shouldn't be blocked by kernel, I'd expect if someone wants to bind
> > this
> > > to another application from userspace they should be able to.
> > 
> > Great! Can I send patch after which 0xe00e will be send to input layer as
> > event KEY_BATTERY?
> > 
> 
> Well that's why I was mentioning this in two places.  If it's received from keyboard
> recoding it as KEY_BATTERY sounds appropriate to me.  If it's received from WMI,
> it really shouldn't be set as anything for Linux to do.
> 
> I don't think any apps will benefit from the notification to re-read battery
> Information today.

I mean for dell-wmi.c code.
Why it should not be set to anything on Linux?

-- 
Pali Rohár
pali.rohar@...il.com