linux-kernel - Re: [Y2038] [PATCH v2 00/24] Delete CURRENT_TIME and CURRENT_TIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5119217.EGiBXE3Be4@wuerfel>
Date:	Wed, 22 Jun 2016 17:49:48 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	y2038@...ts.linaro.org, tglx@...utronix.de,
	linux-ext4@...r.kernel.org, jbacik@...com
Cc:	Deepa Dinamani <deepa.kernel@...il.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	shaggy@...nel.org, jfs-discussion@...ts.sourceforge.net,
	trond.myklebust@...marydata.com, clm@...com,
	adilger.kernel@...ger.ca, zyan@...hat.com, jejb@...ux.vnet.ibm.com,
	paul@...l-moore.com, linux-scsi@...r.kernel.org,
	cm224.lee@...sung.com, mfasheh@...e.com, sramars@...co.com,
	john.stultz@...aro.org, viro@...iv.linux.org.uk, dsterba@...e.com,
	jaegeuk@...nel.org, ceph-devel@...r.kernel.org,
	linux-nfs@...r.kernel.org, elder@...nel.org, tytso@....edu,
	sage@...hat.com, martin.petersen@...cle.com,
	gregkh@...uxfoundation.org, hiralpat@...co.com,
	adrian.hunter@...el.com, eparis@...hat.com,
	linux-f2fs-devel@...ts.sourceforge.net, sfrench@...ba.org,
	linux-audit@...hat.com, ocfs2-devel@....oracle.com, jack@...e.com,
	linux-mtd@...ts.infradead.org, lustre-devel@...ts.lustre.org,
	torvalds@...ux-foundation.org, anna.schumaker@...app.com,
	linux-btrfs@...r.kernel.org, jlbec@...lplan.org
Subject: Re: [Y2038] [PATCH v2 00/24] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

On Sunday, June 19, 2016 5:26:59 PM CEST Deepa Dinamani wrote:
> The series is aimed at getting rid of CURRENT_TIME and CURRENT_TIME_SEC macros.
> The macros are not y2038 safe. There is no plan to transition them into being
> y2038 safe.
> ktime_get_* api's can be used in their place. And, these are y2038 safe.
> 
> Thanks to Arnd Bergmann for all the guidance and discussions.
> 
> Patches 2-4 were mostly generated using coccinelle scripts.
> 
> All filesystem timestamps use current_fs_time() for right granularity as
> mentioned in the respective commit texts of patches. This has a changed
> signature, renamed to current_time() and moved to the fs/inode.c.
> 
> This series also serves as a preparatory series to transition vfs to 64 bit
> timestamps as outlined here: https://lkml.org/lkml/2016/2/12/104 .
> 
> As per Linus's suggestion in https://lkml.org/lkml/2016/5/24/663 , all the
> inode timestamp changes have been squashed into a single patch. Also,
> current_time() now is used as a single generic vfs filesystem timestamp api.
> It also takes struct inode* as argument instead of struct super_block*.
> Posting all patches together in a bigger series so that the big picture is
> clear.
> 
> As per the suggestion in https://lwn.net/Articles/672598/, CURRENT_TIME macro
> bug fixes are being handled in a series separate from transitioning vfs to use.

I've looked in detail at all the patches in this version now, and while
overall everything is fine, I found that two patches cannot be part of the
series because of the dependency on the patch that John already took (adding
time64_to_tm), but I think that's ok because we just need to change over
all the users of CURRENT_TIME and CURRENT_TIME_SEC that assign to inode
timestamps in order to prepare for the type change, the other ones
can be changed later.

I also found a few things that could be done differently to make the
later conversion slightly easier, but it's also possible that I missed
part of your bigger plan for those files, and none of them seem important.

	Arnd