linux-kernel - Re: [PATCH 6/8] nfs: don't use ->d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160622164806.GQ14480@ZenIV.linux.org.uk>
Date:	Wed, 22 Jun 2016 17:48:06 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Miklos Szeredi <mszeredi@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Trond Myklebust <trond.myklebust@...marydata.com>
Subject: Re: [PATCH 6/8] nfs: don't use ->d_time

On Wed, Jun 22, 2016 at 04:35:08PM +0200, Miklos Szeredi wrote:
>  static void nfs_d_release(struct dentry *dentry)
>  {
>  	/* free cached devname value, if it survived that far */
> -	if (unlikely(dentry->d_fsdata)) {
> +	if (unlikely(NFS_D(dentry)->devname)) {
>  		if (dentry->d_flags & DCACHE_NFSFS_RENAMED)
>  			WARN_ON(1);
>  		else
> -			kfree(dentry->d_fsdata);
> +			kfree(NFS_D(dentry)->devname);
>  	}
> +	kfree(dentry->d_fsdata);

Again, is that safe wrt RCU delays?