linux-kernel - Re: [PATCH] x86: fix rdmsr MSR_PLATFORM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aab33eba-e2d7-ff60-6a63-abee2a47cac8@redhat.com>
Date:	Wed, 22 Jun 2016 19:43:15 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Wanpeng Li <kernellwp@...il.com>, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org, Linux PM list <linux-pm@...r.kernel.org>,
	linux-acpi@...r.kernel.org, lkp@...org, x86@...nel.org
Cc:	Wanpeng Li <wanpeng.li@...mail.com>,
	Len Brown <len.brown@...el.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Zhang Rui <rui.zhang@...el.com>, Chen Yu <y.c.chen@...el.com>,
	Radim Krčmář <rkrcmar@...hat.com>,
	jacob.jun.pan@...el.com, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm
 guest



On 22/06/2016 03:28, Wanpeng Li wrote:
>  
>  get_ratio:
> -	rdmsr(MSR_PLATFORM_INFO, lo, hi);
> -	ratio = (lo >> 8) & 0xff;
> +	if (!rdmsr_safe(MSR_PLATFORM_INFO, &lo, &hi))
> +		ratio = (lo >> 8) & 0xff;

This looks good, thanks.

Paolo