linux-kernel - Re: [PATCH 4/4] HID: remove ThingM blink(1) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871t3pkn2o.fsf@ketchup.mtl.sfl>
Date:	Wed, 22 Jun 2016 16:03:59 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Heiner Kallweit <hkallweit1@...il.com>,
	Jiri Kosina <jikos@...nel.org>
Cc:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] HID: remove ThingM blink(1) driver

Hi Heiner,

Heiner Kallweit <hkallweit1@...il.com> writes:

>>> Also adding Vivien Didelot to CC, as the author of the original driver. 
>>> Vivien, the full set can be found in linux-input archives ( 
>>> http://marc.info/?l=linux-input&r=1&b=201606&w=2 )
>> 
>> Thanks a lot for the follow-up Jiri.
>> 
>> If you guys decide to remove hid-thingm.c, you need to update the
>> MAINTAINERS entry, checkpatch.pl should have warned about that.
>> 
> Right, thanks for the hint.
>
>> I can hardly test the patchset now. Heiner, can you confirm me that with
>> your patchset, we will still see 3 led_classdev in sysfs for the
>> blink(1) mk1 (which has one RGB chip) and 6 for mk2 (which has 2 chips)?
>> 
> Yes, this will still be the case.

Looks good to me then! Please Cc' me in the v2 so I can hack the change.

Thanks,

        Vivien