linux-kernel - Re: [PATCH] ACPI : Dummy acpi_video_register should return error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3183729.cNSdjc2YjN@vostro.rjw.lan>
Date:	Wed, 22 Jun 2016 23:05:49 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Arvind Yadav <arvind.yadav.cs@...il.com>,
	Aaron Lu <aaron.lu@...el.com>
Cc:	robert.moore@...el.com, lv.zheng@...el.com,
	rafael.j.wysocki@...el.com, lenb@...nel.org,
	linux-acpi@...r.kernel.org, devel@...ica.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI : Dummy acpi_video_register should return error code

On Thursday, June 23, 2016 12:26:01 AM Arvind Yadav wrote:
> The inline acpi_video_register stub simply allows compilation on systems
> with CONFIG_ACPI_VIDEO disabled. the dummy acpi_video_register does not
> register an acpi_bus_driver at all. The inline acpi_video_register should
> return to indicate lack of support when attempting to register an
> acpi_bus_driver on such a system with CONFIG_ACPI_VIDEO disabled.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  include/acpi/video.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/acpi/video.h b/include/acpi/video.h
> index 5731ccb..4536bd3 100644
> --- a/include/acpi/video.h
> +++ b/include/acpi/video.h
> @@ -54,7 +54,7 @@ extern int acpi_video_get_levels(struct acpi_device *device,
>  				 struct acpi_video_device_brightness **dev_br,
>  				 int *pmax_level);
>  #else
> -static inline int acpi_video_register(void) { return 0; }
> +static inline int acpi_video_register(void) { return -ENODEV; }
>  static inline void acpi_video_unregister(void) { return; }
>  static inline int acpi_video_get_edid(struct acpi_device *device, int type,
>  				      int device_id, void **edid)

Aaron, what do you think?