[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=X-2hu4j13tFh1tog60aEbOaBekCk+QVvDSp0tmr5HE1g@mail.gmail.com>
Date: Wed, 22 Jun 2016 22:16:28 -0700
From: Doug Anderson <dianders@...omium.org>
To: Yakir Yang <ykk@...k-chips.com>
Cc: Mark Yao <yzq@...k-chips.com>, Inki Dae <inki.dae@...sung.com>,
Jingoo Han <jingoohan1@...il.com>,
Heiko Stuebner <heiko@...ech.de>,
Javier Martinez Canillas <javier@....samsung.com>,
Stéphane Marchesin <marcheu@...omium.org>,
Tomasz Figa <tfiga@...omium.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel.vetter@...ll.ch>,
Thierry Reding <treding@...dia.com>,
Krzysztof Kozlowski <k.kozlowski@...sung.com>,
Emil Velikov <emil.l.velikov@...il.com>,
Dan Carpenter <dan.carpenter@...cle.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH v4.1 1/2] drm/rockchip: analogix_dp: introduce the pclk
for grf
Yakir,
On Wed, Jun 22, 2016 at 6:58 PM, Yakir Yang <ykk@...k-chips.com> wrote:
> For RK3399's GRF module, if we want to operate the graphic related grf
> registers, we need to enable the pclk_vio_grf which supply power for VIO
> GRF IOs, so it's better to introduce an optional grf clock in driver.
>
> Signed-off-by: Yakir Yang <ykk@...k-chips.com>
> ---
> Hi all,
>
> This is an external patch for analogix_dp misc cleanup thread [0]
> [0]: https://patchwork.kernel.org/patch/9175613/
>
> BR,
> - Yakir
>
> Changes in v4.1:
> - Fix compiled error, sorry.
> "dp->cgfclk" --> 'dp->grfclk'
>
> Changes in v4:
> - Check the the error code properly, 'EPROBE_DEFER' should be returned,
> 'ENOENT' should assign a NULL point to grfclk, other errors should be
> regarded as failed. (Tomasz, Doug, reviewed at Google Gerrit)
> [https://chromium-review.googlesource.com/#/c/351821/20/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c@249]
> - Add the document about optional 'grf' clock (Tomasz, Doug, reviewed at Google Gerrit)
> [https://chromium-review.googlesource.com/#/c/351821/]
>
> Changes in v3:
> - Add this patch in v3
>
> .../display/rockchip/analogix_dp-rockchip.txt | 6 ++++++
> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 23 +++++++++++++++++++---
> 2 files changed, 26 insertions(+), 3 deletions(-)
I probably would have split into two patches so the bindings was its
own patch, but I don't think it's strictly required.
In any case, this seems good to me.
Reviewed-by: Douglas Anderson <dianders@...omium.org>
Powered by blists - more mailing lists