linux-kernel - Re: [PATCH] acpi: thermal: Remove create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36677760.GlRjyGeQ5Q@vostro.rjw.lan>
Date:	Thu, 23 Jun 2016 02:37 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Tejun Heo <tj@...nel.org>,
	Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:	Zhang Rui <rui.zhang@...el.com>, Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acpi: thermal: Remove create_workqueue

On Tuesday, June 07, 2016 09:13:51 AM Tejun Heo wrote:
> On Tue, Jun 07, 2016 at 08:45:40AM +0530, Bhaktipriya Shridhar wrote:
> > alloc_workqueue replaces deprecated create_workqueue().
> > 
> > A dedicated workqueue has been used since the workqueue
> > acpi_thermal_pm_queue with workitem &tz->thermal_check_work
> > (maps to acpi_thermal_check_fn), is involved in thermal zone polling.
> > Wallclock time is actually important and getting delayed in handling
> > critical temperature event can actually lead to unnecessary hardware
> > damage. So while this is not used during memory reclaim, we still want
> > forward progress guarantee and be generally snappy in servicing it.
> > Hence, WQ_MEM_RECLAIM and WQ_HIGHPRI have been used here.
> > 
> > Since there are only a fixed number of work items, explicit concurrency
> > limit is unnecessary here.
> > 
> > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
> 
> Acked-by: Tejun Heo <tj@...nel.org>

Patch applied, thanks!