linux-kernel - Re: [PATCH v4 1/5] ACPICA: Namespace: Fix a regression that MLC support triggers dead lock in dynamic table loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3048231.eY7WrjAFBo@vostro.rjw.lan>
Date:	Thu, 23 Jun 2016 02:41:07 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	"Zheng, Lv" <lv.zheng@...el.com>
Cc:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"Brown, Len" <len.brown@...el.com>, Lv Zheng <zetalog@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v4 1/5] ACPICA: Namespace: Fix a regression that MLC support triggers dead lock in dynamic table loading

On Tuesday, June 21, 2016 09:55:53 AM Zheng, Lv wrote:
> Hi, Mika
> 
> > From: Mika Westerberg [mailto:mika.westerberg@...ux.intel.com]
> > Subject: Re: [PATCH v4 1/5] ACPICA: Namespace: Fix a regression that MLC
> > support triggers dead lock in dynamic table loading
> > 
> > On Tue, Jun 21, 2016 at 12:34:15PM +0800, Lv Zheng wrote:
> > > The new MLC approach invokes MLC per-table basis. But the dynamic
> > loading
> > > support of this is incorrect because of the lock order:
> > >  acpi_ns_evaluate
> > >    acpi_ex_enter_intperter
> > >      acpi_ns_load_table (triggered by Load opcode)
> > >        acpi_ns_exec_module_code_list
> > >          acpi_ex_enter_intperter
> > > The regression is introduced by the following commit:
> > >   Commit: 2785ce8d0da1cac9d8f78615e116cf929e9a9123
> > >   ACPICA Commit: 071eff738c59eda1792ac24b3b688b61691d7e7c
> > >   Subject: ACPICA: Add per-table execution of module-level code
> > > This patch fixes this regression by unlocking the interpreter lock before
> > > invoking MLC. However the unlocking is done to the
> > acpi_ns_load_table(), in
> > > which, the interpreter lock should be locked by acpi_ns_parse_table()
> > but
> > > wasn't. Reported by Mika Westerberg. Fixed by Lv Zheng.
> > >
> > > Fixes: 2785ce8d0da1 ("ACPICA: Add per-table execution of module-level
> > code")
> > > Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > > Reported-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > 
> > Now builds fine and fixes the hang, thanks :)
> > 
> > Tested-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> [Lv Zheng] 
> Great! :)
> I'll leave the SOB correction for Rafael in order not to bother others by re-sending an update.

Applied (with tags), thanks!