linux-kernel - Re: [PATCH v3] cgroup: Disable IRQs while holding css_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <576B35C3.8070109@huawei.com>
Date:	Thu, 23 Jun 2016 09:05:07 +0800
From:	Zefan Li <lizefan@...wei.com>
To:	Daniel Bristot de Oliveira <bristot@...hat.com>,
	Tejun Heo <tj@...nel.org>
CC:	Rik van Riel <riel@...hat.com>,
	"Luis Claudio R. Goncalves" <lgoncalv@...hat.com>,
	<stable@...r.kernel.org>, Johannes Weiner <hannes@...xchg.org>,
	Juri Lelli <juri.lelli@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	<cgroups@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] cgroup: Disable IRQs while holding css_set_lock

On 2016/6/23 4:28, Daniel Bristot de Oliveira wrote:
> While testing the deadline scheduler + cgroup setup I hit this
> warning.
> 
...
> The warn is the spin_(lock|unlock)_bh(&css_set_lock) in the interrupt
> context. Converting the spin_lock_bh to spin_lock_irq(save) to avoid
> this problem - and other problems of sharing a spinlock with an
> interrupt.
> 
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Li Zefan <lizefan@...wei.com>
> Cc: Johannes Weiner <hannes@...xchg.org>
> Cc: Juri Lelli <juri.lelli@....com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: cgroups@...r.kernel.org
> Cc: stable@...r.kernel.org # 4.5+
> Cc: linux-kernel@...r.kernel.org
> Reviewed-by: Rik van Riel <riel@...hat.com>
> Reviewed-by: "Luis Claudio R. Goncalves" <lgoncalv@...hat.com>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@...hat.com>
> 

Acked-by: Zefan Li <lizefan@...wei.com>