linux-kernel - Re: [PATCH 0/2] fujitsu-laptop: Debugging cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160623103535.GA18242@marvin.atrad.com.au>
Date:	Thu, 23 Jun 2016 20:05:35 +0930
From:	Jonathan Woithe <jwoithe@...t42.net>
To:	Micha?? K??pie?? <kernel@...pniu.pl>
Cc:	Darren Hart <dvhart@...radead.org>,
	Jan-Marek Glogowski <glogow@...home.de>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] fujitsu-laptop: Debugging cleanup

On Thu, Jun 23, 2016 at 12:02:46PM +0200, Micha?? K??pie?? wrote:
> vdbg_printk() was introduced by 20b9373, which is the same commit that
> adds FUJ02E3 support, so it has been the way it is now from the start.
> This patch series attempts to tidy things up a bit.
> 
>  drivers/platform/x86/fujitsu-laptop.c |   12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)

Yes, good idea.  Both patches look good to me.  I would like to note in
passing that the removal of the unused defines in the second patch was in
fact suggested as part of a broader cleanup series by Alan Jenkins an
embarassingly long time ago.  For various reasons I didn't get a chance to
review and apply his patch series at the time.  It is my aim to rectify this
soon, but in the meantime this two patch series is good to go in.  Thanks
for the submission.

Acked-by: Jonathan Woithe <jwoithe@...t42.net>

Regards
  jonathan