linux-kernel - Re: [PATCH] x86: fix unused efi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Jun 2016 14:32:05 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	y2038@...ts.linaro.org, Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: fix unused efi_get_time function

On Fri, 17 Jun, at 04:51:29PM, Arnd Bergmann wrote:
> Nothing calls the efi_get_time function on x86, but it does suffer
> from the 32-bit time_t overflow in 2038.
> 
> To avoid that if anyone starts calling it, this changes the function
> to use timespec64 and mktime64 instead.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> The obvious alternative would be to remove the function, I'll send
> that patch as well, so you can pick one or the other.
> 
>  arch/x86/platform/efi/efi.c | 6 +++---
>  include/linux/efi.h         | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
 
Looks good, thanks Arnd!