linux-kernel - Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification when target() is failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h41W6SCpEOvwEW1Mj=C5ZyoC7gA4OpMi6cdECqM7oGZw@mail.gmail.com>
Date:	Thu, 23 Jun 2016 15:40:37 +0200
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>,
	Myungjoo Ham <myungjoo.ham@...sung.com>
Cc:	kyungmin.park@...sung.com, hl@...k-chips.com,
	Rafael Wysocki <rafael.j.wysocki@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] PM / devfreq: Send the DEVFREQ_POSTCHANGE notification
 when target() is failed

On Thu, Jun 23, 2016 at 4:18 AM, Chanwoo Choi <cw00.choi@...sung.com> wrote:
> This patch sends the DEVFREQ_POSTCHANGE notification when
> devfreq->profile->targer() is failed. The PRECHANGE/POSTCHANGE
> should be paired.
>
> Fixes: 0fe3a66410a3 ("PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier")
> Reported-by: Lin Huang <hl@...k-chips.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> ---
>  drivers/devfreq/devfreq.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 1d6c803804d5..387799fec4c3 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -268,8 +268,11 @@ int update_devfreq(struct devfreq *devfreq)
>         devfreq_notify_transition(devfreq, &freqs, DEVFREQ_PRECHANGE);
>
>         err = devfreq->profile->target(devfreq->dev.parent, &freq, flags);
> -       if (err)
> +       if (err) {
> +               freqs.new = cur_freq;
> +               devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
>                 return err;
> +       }
>
>         freqs.new = freq;
>         devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
> --

This looks like a fix for a recent regression, so I can apply it directly.

Do you want me to do that?

Thanks,
Rafael