linux-kernel - Re: [PATCH 02/11] x86/efi: Consolidate region mapping logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160623140028.GD20951@nazgul.tnic>
Date:	Thu, 23 Jun 2016 16:00:28 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Matt Fleming <matt@...eblueprint.co.uk>
Cc:	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Dave Young <dyoung@...hat.com>, linux-kernel@...r.kernel.org,
	linux-efi@...r.kernel.org
Subject: Re: [PATCH 02/11] x86/efi: Consolidate region mapping logic

On Thu, Jun 23, 2016 at 12:34:41PM +0100, Matt Fleming wrote:
> EFI regions are currently mapped in two separate places. The bulk of
> the work is done in efi_map_regions() but when CONFIG_EFI_MIXED is
> enabled the additional regions that are required when operating in
> mixed mode are mapping in efi_setup_page_tables().
> 
> Pull everything into efi_map_regions() and refactor the test for
> which regions should be mapped into a should_map_region() function.
> Generously sprinkle comments to clarify the different cases.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Signed-off-by: Matt Fleming <matt@...eblueprint.co.uk>
> ---
>  arch/x86/platform/efi/efi.c    | 50 ++++++++++++++++++++++++++++++++++++------
>  arch/x86/platform/efi/efi_64.c | 20 -----------------
>  2 files changed, 43 insertions(+), 27 deletions(-)

Looks good.

Acked-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--