lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Jun 2016 10:22:58 -0400 From: Sean Paul <seanpaul@...omium.org> To: Yakir Yang <ykk@...k-chips.com> Cc: Mark Yao <yzq@...k-chips.com>, Inki Dae <inki.dae@...sung.com>, Jingoo Han <jingoohan1@...il.com>, Heiko Stuebner <heiko@...ech.de>, Krzysztof Kozlowski <k.kozlowski@...sung.com>, linux-samsung-soc <linux-samsung-soc@...r.kernel.org>, linux-rockchip@...ts.infradead.org, Daniel Vetter <daniel.vetter@...ll.ch>, Emil Velikov <emil.l.velikov@...il.com>, Douglas Anderson <dianders@...omium.org>, dri-devel <dri-devel@...ts.freedesktop.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Javier Martinez Canillas <javier@....samsung.com>, Tomasz Figa <tomasz.figa@...omium.com>, Stéphane Marchesin <marcheu@...omium.org>, Thierry Reding <treding@...dia.com>, Dan Carpenter <dan.carpenter@...cle.com> Subject: Re: [PATCH v3 09/10] drm/rockchip: analogix_dp: update the comments about why need to hardcode VOP output mode On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang <ykk@...k-chips.com> wrote: > The hardware IC designed that VOP must output the RGB10 video format to > eDP contoller, and if eDP panel only support RGB8, then eDP contoller > should cut down the video data, not via VOP contoller, that's why we need > to hardcode the VOP output mode to RGA10 here. > > Signed-off-by: Yakir Yang <ykk@...k-chips.com> > Acked-by: Mark Yao <mark.yao@...k-chips.com> > Reviewed-by: Tomasz Figa <tomasz.figa@...omium.com> > --- > Changes in v3: > - Add the reviewed flag from Tomasz. > [https://chromium-review.googlesource.com/#/c/346853/12] > - Add the acked flag from Mark. > > Changes in v2: > - new patch in v2 > > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index 95a6f60..2ceb3f9 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -173,17 +173,11 @@ rockchip_dp_drm_encoder_atomic_check(struct drm_encoder *encoder, > int ret; > > /* > - * FIXME(Yakir): driver should configure the CRTC output video > - * mode with the display information which indicated the monitor > - * support colorimetry. > - * > - * But don't know why the CRTC driver seems could only output the > - * RGBaaa rightly. For example, if connect the "innolux,n116bge" > - * eDP screen, EDID would indicated that screen only accepted the > - * 6bpc mode. But if I configure CRTC to RGB666 output, then eDP > - * screen would show a blue picture (RGB888 show a green picture). > - * But if I configure CTRC to RGBaaa, and eDP driver still keep > - * RGB666 input video mode, then screen would works prefect. > + * The hardware IC designed that VOP must output the RGB10 video > + * format to eDP contoller, and if eDP panel only support RGB8, > + * then eDP contoller should cut down the video data, not via VOP > + * contoller, that's why we need to hardcode the VOP output mode > + * to RGA10 here. s/contoller/controller/ > */ > > ret = drm_of_encoder_active_endpoint_id(dp->dev->of_node, encoder); > -- > 1.9.1 > > > _______________________________________________ > dri-devel mailing list > dri-devel@...ts.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists