linux-kernel - Re: [PATCH] dsa: mv88e6xxx: hide unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fus4x760.fsf@ketchup.mtl.sfl>
Date:	Thu, 23 Jun 2016 11:21:27 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Arnd Bergmann <arnd@...db.de>,
	"David S. Miller" <davem@...emloft.net>
Cc:	Arnd Bergmann <arnd@...db.de>, Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dsa: mv88e6xxx: hide unused functions

Hi,

Arnd Bergmann <arnd@...db.de> writes:

> When CONFIG_NET_DSA_HWMON is disabled, we get warnings about two unused
> functions whose only callers are all inside of an #ifdef:
>
> drivers/net/dsa/mv88e6xxx.c:3257:12: 'mv88e6xxx_mdio_page_write' defined but not used [-Werror=unused-function]
> drivers/net/dsa/mv88e6xxx.c:3244:12: 'mv88e6xxx_mdio_page_read' defined but not used [-Werror=unused-function]
>
> This adds another ifdef around the function definitions. The warnings
> appeared after the functions were marked 'static', but the problem
> was already there before that.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 57d3231057e9 ("net: dsa: mv88e6xxx: fix style issues")

Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

David, this patch is meant for net-next. It applies cleanly *before* my
last two submissions:

    1/2 http://patchwork.ozlabs.org/patch/638773/
    2/2 http://patchwork.ozlabs.org/patch/638772/

Thanks,

        Vivien