linux-kernel - Re: [PATCH v2] pwm: improve args checking in pwm_apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160623165508.GA20051@ulmo.ba.sec>
Date:	Thu, 23 Jun 2016 18:55:08 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Brian Norris <briannorris@...omium.org>
Cc:	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Linux PWM List <linux-pwm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Brian Norris <computersforpeace@...il.com>,
	Doug Anderson <dianders@...omium.org>,
	linux-renesas-soc@...r.kernel.org,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH v2] pwm: improve args checking in pwm_apply_state()

On Wed, Jun 22, 2016 at 01:46:48PM -0700, Brian Norris wrote:
> On Wed, Jun 22, 2016 at 10:41:14PM +0200, Boris Brezillon wrote:
> > On Wed, 22 Jun 2016 12:16:59 -0700
> > Brian Norris <briannorris@...omium.org> wrote:
> > > Notably, you're dropping the 'if (!pwm) { }' safety checks that are part
> > > of pwm_disable() and pwm_set_polarity(). But I don't think there should
> > > be any users relying on that.
> > 
> > Indeed. I can add it back here if you prefer,
> 
> Nah, that's ok. I just had to say it anyway :)
> 
> > but honestly, PWM users
> > that are not checking the value returned by pwm_get() should be
> > considered buggy IMHO, and a NULL pointer exception is a good way to
> > make people realize they are not properly using the API :).
> 
> Seems OK.

I've applied this to my fixes branch, and I'll let it cook in linux-next
for a little while, then send it off to Linus for v4.7-rc6 next week if
no further fallout is caused by this.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)