linux-kernel - Re: [PATCH] Coccinelle: Add misc/boolconv.cocci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <576C36E5.9030909@ti.com>
Date:	Thu, 23 Jun 2016 14:22:13 -0500
From:	"Andrew F. Davis" <afd@...com>
To:	Joe Perches <joe@...ches.com>, Julia Lawall <Julia.Lawall@...6.fr>,
	Gilles Muller <Gilles.Muller@...6.fr>,
	Nicolas Palix <nicolas.palix@...g.fr>,
	Michal Marek <mmarek@...e.com>
CC:	<cocci@...teme.lip6.fr>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Coccinelle: Add misc/boolconv.cocci

On 06/23/2016 02:12 PM, Joe Perches wrote:
> On Thu, 2016-06-23 at 13:53 -0500, Andrew F. Davis wrote:
>> Add a script to check for unneeded conversions to bool.
> 
> this could also be extended for bool functions that:
> 
> 	return !!expression;
> and
> 	return expression != 0;
> 

Agreed, it's in the works, I was going to post this current set with
some patches to the kernel that is detects, then add additional checks
and their kernel fixes incrementally.

For the second suggestion I think we could have additions to
boolinit.cocci that include the results of comparison/logical operations.

Thanks,
Andrew