lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <576C3DAD.60107@canonical.com>
Date:	Thu, 23 Jun 2016 20:51:09 +0100
From:	Colin Ian King <colin.king@...onical.com>
To:	Eli Billauer <eli.billauer@...il.com>,
	Joe Perches <joe@...ches.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" ->
 "upgrade"

On 23/06/16 20:23, Eli Billauer wrote:
> This is getting increasingly embarrassing. I suppose a single patch,
> fixing both silly mistakes (of mine), would be in place.
> 
> Colin, would you prefer to submit a patch with both issues fixed
> yourself, or should I take care of it?

Eli, I don't mind if you fix it up.

> 
> Thanks, both of you.
>    Eli
> 
> On 23/06/16 22:05, Joe Perches wrote:
>> On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote:
>>   
>>> trivial fix to spelling mistake in dev_err message
>>>      
>> []
>>   
>>> diff --git a/drivers/char/xillybus/xillybus_core.c
>>> b/drivers/char/xillybus/xillybus_core.c
>>>      
>> []
>>   
>>> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint
>>> *endpoint)
>>>       /* Check version number. Accept anything below 0x82 for now. */
>>>       if (*version>  0x82) {
>>>      
>> trivia:  code doesn't match comment above it.
>>
>>   
>>>           dev_err(endpoint->dev,
>>> -            "No support for IDT version 0x%02x. Maybe the xillybus
>>> driver needs an upgarde. Aborting.\n",
>>> +            "No support for IDT version 0x%02x. Maybe the xillybus
>>> driver needs an upgrade. Aborting.\n",
>>>               *version);
>>>           return -ENODEV;
>>>       }
>>>      
>>    
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ