linux-kernel - Re: [PATCH 1/4] drivers: input: powerkey for HISI 65xx SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Jun 2016 13:31:28 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Lee Jones <lee.jones@...aro.org>,
	Feng Chen <puck.chen@...ilicon.com>,
	Wei Xu <xuwei5@...ilicon.com>,
	Guodong Xu <guodong.xu@...aro.org>
Subject: Re: [PATCH 1/4] drivers: input: powerkey for HISI 65xx SoC

On Wed, Jun 22, 2016 at 5:47 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> On Tue, Jun 21, 2016 at 05:06:23PM -0700, John Stultz wrote:
>> On Tue, Jun 14, 2016 at 3:43 PM, John Stultz <john.stultz@...aro.org> wrote:
>> > From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>
>> >
>> > This driver provides a input driver for the power button on the
>> > HiSi 65xx SoC for boards like HiKey.
>> >
>> > This driver was originally by Zhiliang Xue <xuezhiliang@...wei.com>
>> > then basically rewritten by Jorge, but preserving the original
>> > module author credits.
>> >
>> > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
>> > Cc: Rob Herring <robh+dt@...nel.org>
>> > Cc: Lee Jones <lee.jones@...aro.org>
>> > Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>
>> > Cc: Feng Chen <puck.chen@...ilicon.com>
>> > Cc: Wei Xu <xuwei5@...ilicon.com>
>> > Cc: Guodong Xu <guodong.xu@...aro.org>
>> > Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>
>> > [jstultz: Reworked commit message, folded in other fixes/cleanups
>> > from Jorge, implemented some larger cleanups suggested by DmitryT]
>> > Signed-off-by: John Stultz <john.stultz@...aro.org>
>> > ---
>> > v2: Major rework integrating feedback from Dmitry.
>> > v3: Dropped of_match compatible line since no longer using DT
>> >     for this.
>> > v4: Removed MODULE_DEVICE_TABLE(of, hi65xx_powerkey_of_match) line
>> >     I missed in the last revision, which casued build issues w/
>> >     modules.
>>
>> Hey Dmitry,
>>   Just wanted to ping you to see if there was anything else you were
>> wanting changed with this patch. Lee has queued the mfd patches in
>> -next, so I wanted to be sure to address any concerns you had that was
>> keeping this from heading upstream in 4.8 (hopefully :).
>
> Right, sorry, does the following look OK to you?
>

Yes! It looks great (and I tested it works too)!

Do you want to fold that in, or do you need me to re-submit with those changes?

thanks
-john