linux-kernel - Re: [PATCH v2 11/13] sched/fair: Avoid pulling tasks from non-overloaded higher capacity groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <576C52B0.5080504@nvidia.com>
Date:	Thu, 23 Jun 2016 14:20:48 -0700
From:	Sai Gurrappadi <sgurrappadi@...dia.com>
To:	Morten Rasmussen <morten.rasmussen@....com>,
	<peterz@...radead.org>, <mingo@...hat.com>
CC:	<dietmar.eggemann@....com>, <yuyang.du@...el.com>,
	<vincent.guittot@...aro.org>, <mgalbraith@...e.de>,
	<linux-kernel@...r.kernel.org>,
	Peter Boonstoppel <pboonstoppel@...dia.com>
Subject: Re: [PATCH v2 11/13] sched/fair: Avoid pulling tasks from non-overloaded
 higher capacity groups

Hi Morten,

On 06/22/2016 10:03 AM, Morten Rasmussen wrote:

[...]

>  
> +/*
> + * group_smaller_cpu_capacity: Returns true if sched_group sg has smaller
> + * per-cpu capacity than sched_group ref.
> + */
> +static inline bool
> +group_smaller_cpu_capacity(struct sched_group *sg, struct sched_group *ref)
> +{
> +	return sg->sgc->max_capacity * capacity_margin <
> +						ref->sgc->max_capacity * 1024;
> +}
> +
>  static inline enum
>  group_type group_classify(struct sched_group *group,
>  			  struct sg_lb_stats *sgs)
> @@ -6892,6 +6903,19 @@ static bool update_sd_pick_busiest(struct lb_env *env,
>  	if (sgs->avg_load <= busiest->avg_load)
>  		return false;
>  
> +	if (!(env->sd->flags & SD_ASYM_CPUCAPACITY))
> +		goto asym_packing;
> +
> +	/* Candidate sg has no more than one task per cpu and has
> +	 * higher per-cpu capacity. Migrating tasks to less capable
> +	 * cpus may harm throughput. Maximize throughput,
> +	 * power/energy consequences are not considered.
> +	 */
> +	if (sgs->sum_nr_running <= sgs->group_weight &&
> +	    group_smaller_cpu_capacity(sds->local, sg))
> +		return false;
> +
> +asym_packing:

What about the case where IRQ/RT work reduces the capacity of some of these bigger CPUs? sgc->max_capacity might not necessarily capture that case.

Thanks,
-Sai