linux-kernel - Re: [PATCH 3/3] rt-tests: Add cyclicdeadline and deadline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160623174746.36d3657d@gandalf.local.home>
Date:	Thu, 23 Jun 2016 17:47:46 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	John Kacur <jkacur@...hat.com>
Cc:	rt-users <linux-rt-users@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Clark Williams <williams@...hat.com>
Subject: Re: [PATCH 3/3] rt-tests: Add cyclicdeadline and deadline_test to
 the Make system

On Thu, 23 Jun 2016 14:11:51 +0200
John Kacur <jkacur@...hat.com> wrote:


> index 9c50456f7419..f530488545e0 100644
> --- a/src/sched_deadline/cyclicdeadline.c
> +++ b/src/sched_deadline/cyclicdeadline.c
> @@ -1,4 +1,6 @@
> +#ifndef _GNU_SOURCE
>  #define _GNU_SOURCE
> +#endif
>  #include <pthread.h>
>  #include <stdarg.h>
>  #include <stdlib.h>
> diff --git a/src/sched_deadline/deadline_test.c b/src/sched_deadline/deadline_test.c
> index 8a813c494520..2794730febc4 100644
> --- a/src/sched_deadline/deadline_test.c
> +++ b/src/sched_deadline/deadline_test.c
> @@ -29,7 +29,9 @@
>   *    Look for "simple_test"
>   *
>   */
> +#ifndef _GNU_SOURCE
>  #define _GNU_SOURCE
> +#endif

I'd say nuke these if they are already defined via the Makefile or
something. I can move the define to the Makefile in my github too.

-- Steve

>  #include <pthread.h>
>  #include <stdarg.h>
>  #include <stdlib.h>