linux-kernel - Re: [PATCH V3] clocksource/drivers/arc: Convert init function to return error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <576CB1B6.9090003@synopsys.com>
Date:	Fri, 24 Jun 2016 09:36:14 +0530
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>, <tglx@...utronix.de>
CC:	<linux-kernel@...r.kernel.org>,
	<linux-snps-arc@...ts.infradead.org>
Subject: Re: [PATCH V3] clocksource/drivers/arc: Convert init function to
 return error

On Friday 17 June 2016 03:39 PM, Daniel Lezcano wrote:
> The init functions do not return any error. They behave as the following:
> 
>   - panic, thus leading to a kernel crash while another timer may work and
>        make the system boot up correctly
> 
>   or
> 
>   - print an error and let the caller unaware if the state of the system
> 
> Change that by converting the init functions to return an error conforming
> to the CLOCKSOURCE_OF_RET prototype.
> 
> Proper error handling (rollback, errno value) will be changed later case
> by case, thus this change just return back an error or success in the init
> function.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  arch/arc/kernel/time.c | 69 ++++++++++++++++++++++++++++++--------------------

[...]

>  	evt->cpumask = cpumask_of(smp_processor_id());
> @@ -347,24 +355,31 @@ static void __init arc_clockevent_setup(struct device_node *node)
>  	/* Needs apriori irq_set_percpu_devid() done in intc map function */
>  	ret = request_percpu_irq(arc_timer_irq, timer_irq_handler,
>  				 "Timer0 (per-cpu-tick)", evt);
> -	if (ret)
> -		panic("clockevent: unable to request irq\n");
> +	if (ret) {
> +		pr_err("clockevent: unable to request irq\n");
> +		returnr ret;

oops I missed the typo here !
Daniel can u squash this to ur patch !

-Vineet