linux-kernel - Re: [PATCH] clk: fixed-factor: add optional dt-binding clock-flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201606241358.FP6REWZM%fengguang.wu@intel.com>
Date:	Fri, 24 Jun 2016 13:57:50 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jongsung Kim <neidhard.kim@....com>
Cc:	kbuild-all@...org,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Mike Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>, linux-clk@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Chanho Min <chanho.min@....com>,
	Jongsung Kim <neidhard.kim@....com>
Subject: Re: [PATCH] clk: fixed-factor: add optional dt-binding clock-flags

Hi,

[auto build test WARNING on robh/for-next]
[also build test WARNING on v4.7-rc4 next-20160623]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jongsung-Kim/clk-fixed-factor-add-optional-dt-binding-clock-flags/20160624-115201
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux for-next
config: microblaze-mmu_defconfig (attached as .config)
compiler: microblaze-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=microblaze 

All warnings (new ones prefixed by >>):

   drivers/clk/clk-fixed-factor.c: In function 'of_fixed_factor_clk_setup':
>> drivers/clk/clk-fixed-factor.c:170:2: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type
     of_property_read_u32(node, "clock-flags", &flags);
     ^
   In file included from include/linux/clk-provider.h:15:0,
                    from drivers/clk/clk-fixed-factor.c:11:
   include/linux/of.h:916:19: note: expected 'u32 *' but argument is of type 'long unsigned int *'
    static inline int of_property_read_u32(const struct device_node *np,
                      ^

vim +/of_property_read_u32 +170 drivers/clk/clk-fixed-factor.c

   154		u32 div, mult;
   155	
   156		if (of_property_read_u32(node, "clock-div", &div)) {
   157			pr_err("%s Fixed factor clock <%s> must have a clock-div property\n",
   158				__func__, node->name);
   159			return;
   160		}
   161	
   162		if (of_property_read_u32(node, "clock-mult", &mult)) {
   163			pr_err("%s Fixed factor clock <%s> must have a clock-mult property\n",
   164				__func__, node->name);
   165			return;
   166		}
   167	
   168		of_property_read_string(node, "clock-output-names", &clk_name);
   169		parent_name = of_clk_get_parent_name(node, 0);
 > 170		of_property_read_u32(node, "clock-flags", &flags);
   171	
   172		clk = clk_register_fixed_factor(NULL, clk_name, parent_name, flags,
   173						mult, div);
   174		if (!IS_ERR(clk))
   175			of_clk_add_provider(node, of_clk_src_simple_get, clk);
   176	}
   177	EXPORT_SYMBOL_GPL(of_fixed_factor_clk_setup);
   178	CLK_OF_DECLARE(fixed_factor_clk, "fixed-factor-clock",

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (12638 bytes)