linux-kernel - Re: [PATCH] mwifiex: Fixed endianness for event TLV type TLV_BTCOEX_WL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Jun 2016 12:26:56 +0530
From:	Prasun Maiti <prasunmaiti87@...il.com>
To:	Amitkumar Karwar <akarwar@...vell.com>,
	Nishant Sarmukadam <nishants@...vell.com>,
	Kalle Valo <kvalo@...eaurora.org>
Cc:	Linux Wireless <linux-wireless@...r.kernel.org>,
	Linux Next <linux-next@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mwifiex: Fixed endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

On Thu, Jun 16, 2016 at 9:49 AM, Prasun Maiti <prasunmaiti87@...il.com> wrote:
> The two members min_scan_time and max_scan_time of structure
> "mwifiex_ie_types_btcoex_scan_time" are of two bytes each. The values
> are assigned directtly from firmware without endian conversion handling.
> So, wrong datas will get saved in big-endian systems.
>
> This patch converts the values into cpu's byte order before assigning them
> into the local members.
>
> Signed-off-by: Prasun Maiti <prasunmaiti87@...il.com>
> ---
>  drivers/net/wireless/marvell/mwifiex/sta_event.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/sta_event.c b/drivers/net/wireless/marvell/mwifiex/sta_event.c
> index 0104108..7dff452 100644
> --- a/drivers/net/wireless/marvell/mwifiex/sta_event.c
> +++ b/drivers/net/wireless/marvell/mwifiex/sta_event.c
> @@ -474,8 +474,8 @@ void mwifiex_bt_coex_wlan_param_update_event(struct mwifiex_private *priv,
>                         scantlv =
>                             (struct mwifiex_ie_types_btcoex_scan_time *)tlv;
>                         adapter->coex_scan = scantlv->coex_scan;
> -                       adapter->coex_min_scan_time = scantlv->min_scan_time;
> -                       adapter->coex_max_scan_time = scantlv->max_scan_time;
> +                       adapter->coex_min_scan_time = le16_to_cpu(scantlv->min_scan_time);
> +                       adapter->coex_max_scan_time = le16_to_cpu(scantlv->max_scan_time);
>                         break;
>
>                 default:
> --
> 1.9.1
>

Hi Amitkumar,

Please let me know your opinion about this patch.

-- 
Thanks,
Prasun