linux-kernel - Re: [PATCH] Validate num_values for HIDIOCGUSAGES, HIDIOCSUSAGES commands.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1606241021490.6874@cbobk.fhfr.pm>
Date:	Fri, 24 Jun 2016 10:22:29 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Scott Bauer <sbauer@...donthack.me>
cc:	benjamin.tissoires@...hat.com, wmealing@...hat.com,
	linux-usb@...r.kernel.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org
Subject: Re: [PATCH] Validate num_values for HIDIOCGUSAGES, HIDIOCSUSAGES
 commands.

On Thu, 23 Jun 2016, Scott Bauer wrote:

> This patch validates the num_values parameter from userland during
> the HIDIOCGUSAGES and HIDIOCSUSAGES commands. Previously, if the
> report id was set to HID_REPORT_ID_UNKNOWN, we would fail to
> validate the num_values parameter leading to a heap overflow.

Thanks for the fix. I've added Cc: stable, applied it to 
for-4.7/upstream-fixes branch, and will be including it in a pull request 
to Linus shortly.

-- 
Jiri Kosina
SUSE Labs