linux-kernel - Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160624125538.GA18012@krava>
Date:	Fri, 24 Jun 2016 14:55:38 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	pi3orama <pi3orama@....com>
Cc:	Wang Nan <wangnan0@...wei.com>, acme@...nel.org,
	linux-kernel@...r.kernel.org, lizefan@...wei.com
Subject: Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to
 CTF

On Fri, Jun 24, 2016 at 08:33:27PM +0800, pi3orama wrote:

SNIP

> > I can't compile unless I can include config.h
> > 
> > [jolsa@...va perf]$ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1
> >  BUILD:   Doing 'make -j4' parallel build
> >  CC       util/data-convert-bt.o
> > util/data-convert-bt.c: In function ‘convert__config’:
> > util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
> >   c->queue_size = perf_config_u64(var, value);
> >                   ^
> > util/data-convert-bt.c:1299:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs]
> >   c->queue_size = perf_config_u64(var, value);
> >   ^
> > util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
> > util/data-convert-bt.c:1332:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration]
> >  perf_config(convert__config, &c);
> >  ^
> > util/data-convert-bt.c:1332:2: error: nested extern declaration of ‘perf_config’ [-Werror=nested-externs]
> > cc1: all warnings being treated as errors
> > 
> 
> Strange.
> 
> The error message seems unrelated to my
> patch, right?

yep, it's unrelated and I just posted the fix

I haven't enabled/compiled this code for a while and that's
what I've got.. I assume we're using different compilers

jirka