lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Jun 2016 10:13:26 +0800 From: Shunqian Zheng <zhengsq@...k-chips.com> To: joro@...tes.org, heiko@...ech.de, robh+dt@...nel.org, mark.rutland@....com, linux@...linux.org.uk, mark.yao@...k-chips.com, airlied@...ux.ie, tfiga@...gle.com, xxm@...k-chips.com Cc: linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux-foundation.org, devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org, Shunqian Zheng <zhengsq@...k-chips.com>, Tomasz Figa <tfiga@...omium.org> Subject: [PATCH v5 1/8] iommu/rockchip: Fix devm_{request,free}_irq parameter From: Simon Xue <xxm@...k-chips.com> Even though the IOMMU shares IRQ with its master, the struct device passed to {request,free}_irq is supposed to represent the device that is signalling the interrupt. This patch makes the driver use IOMMU device instead of master's device to make things clear. Signed-off-by: Simon Xue <xxm@...k-chips.com> Signed-off-by: Shunqian Zheng <zhengsq@...k-chips.com> Reviewed-by: Douglas Anderson <dianders@...omium.org> Signed-off-by: Tomasz Figa <tfiga@...omium.org> --- drivers/iommu/rockchip-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 25b4627..5a9659a 100644 --- a/drivers/iommu/rockchip-iommu.c +++ b/drivers/iommu/rockchip-iommu.c @@ -807,7 +807,7 @@ static int rk_iommu_attach_device(struct iommu_domain *domain, iommu->domain = domain; - ret = devm_request_irq(dev, iommu->irq, rk_iommu_irq, + ret = devm_request_irq(iommu->dev, iommu->irq, rk_iommu_irq, IRQF_SHARED, dev_name(dev), iommu); if (ret) return ret; @@ -860,7 +860,7 @@ static void rk_iommu_detach_device(struct iommu_domain *domain, } rk_iommu_disable_stall(iommu); - devm_free_irq(dev, iommu->irq, iommu); + devm_free_irq(iommu->dev, iommu->irq, iommu); iommu->domain = NULL; -- 1.9.1
Powered by blists - more mailing lists