linux-kernel - Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Jun 2016 15:40:10 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Raashid Muhammed <raashidmuhammed@...ogic.com>
Cc:	nicolas.ferre@...el.com, plagnioj@...osoft.com, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.

Hi,

On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
> Add power led node and rename status led node.
> 

Well, I'm ok with the change but this does more:

> Signed-off-by: Raashid Muhammed <raashidmuhammed@...ogic.com>
> Reviewed-by: Vijay Kumar B. <vijaykumar@...vegnu.org>
> ---
>  arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
> index be409f2..814753a 100644
> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
> @@ -106,11 +106,16 @@
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		b0 {
> -			label = "b0";
> -			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
> -			linux,default-trigger = "heartbeat";
> +		pwr_led {
> +			label = "sam9-l9260:yellow:pwr";
> +			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "cpu0";
>  		};
>  
> +		status_led {
> +			label = "sam9-l9260:green:status";
> +			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
> +			linux,default-trigger = "timer";

This trigger is also switched from heartbeat to timer, is this
intentional?

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com