linux-kernel - Re: [PATCH 1/5] hwmon: (tmp102) Use devm_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Jun 2016 07:30:57 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Nishanth Menon <nm@...com>, Jean Delvare <jdelvare@...e.com>
Cc:	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] hwmon: (tmp102) Use devm_add_action to register
 cleanup function

Hi Nishanth,

On 06/24/2016 07:13 AM, Nishanth Menon wrote:
> On 06/23/2016 07:28 PM, Guenter Roeck wrote:
>> By registering a cleanup function with devm_add_action(), we can
>> simplify the error path in the probe function and drop the remove
>> function entirely.
>>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>
> I dont seem to have a cover letter to reply to... but anyways..
>
> Before: http://pastebin.ubuntu.com/17801376/
> After all 5 patches: http://pastebin.ubuntu.com/17801824/
>
> Fails on beagleboard-X15 with:
> [   36.781509] tmp102 0-0048: No cache defaults, reading back from HW
> [   36.795940] tmp102 0-0048: unexpected config register value
>
> I have'nt bisected down on the specific patch in the series. Have you had a chance to test the series?
>
>

Thanks for testing. Yes, I did test it. Maybe different chip revisions, or different
initial config register values and I messed up there. Can you send me the output
of i2cdump (word wide) ?

Thanks,
Guenter